Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endpoint output unnecessarily sensitive #2248

Closed
wyardley opened this issue Jan 21, 2025 · 0 comments · Fixed by #2249
Closed

endpoint output unnecessarily sensitive #2248

wyardley opened this issue Jan 21, 2025 · 0 comments · Fixed by #2249
Assignees
Labels
bug Something isn't working good first issue Good for newcomers triaged Scoped and ready for work

Comments

@wyardley
Copy link
Contributor

TL;DR

Is there a reason the endpoint output is marked sensitive? AFAICT, this is typically just the public or private IP address. I couldn't easily find a reference in the git history for why this is marked as sensitive.

My proposal is that, absent any reason I'm not understanding where this output may contain actually sensitive information, that the sensitive = true attribute be removed.

Expected behavior

kubernetes_endpoint = 10.0.0.1

Observed behavior

kubernetes_endpoint = <sensitive>

Terraform Configuration

module "foo_gke" {
  source  = "terraform-google-modules/kubernetes-engine/google//modules/beta-autopilot-private-cluster"
  version = "~> 35.0"
[...]
}

output "kubernetes_endpoint" {
  description = "The cluster endpoint"
  sensitive   = true
  value       = module.foo_gke.endpoint
}

Terraform Version

Terraform v1.10.2
on darwin_arm64
+ provider registry.terraform.io/hashicorp/google v5.45.0
+ provider registry.terraform.io/hashicorp/google-beta v5.45.0
+ provider registry.terraform.io/hashicorp/kubernetes v2.35.1
+ provider registry.terraform.io/hashicorp/random v3.6.3

Additional information

No response

@wyardley wyardley added the bug Something isn't working label Jan 21, 2025
wyardley added a commit to wyardley/terraform-google-kubernetes-engine that referenced this issue Jan 21, 2025
It doesn't appear there's any clear reason that the `endpoint` output
needs to be sensitive.
Fixes terraform-google-modules#2248
wyardley added a commit to wyardley/terraform-google-kubernetes-engine that referenced this issue Jan 21, 2025
It doesn't appear there's any clear reason that the `endpoint` output
needs to be sensitive.
Fixes terraform-google-modules#2248
@apeabody apeabody added good first issue Good for newcomers triaged Scoped and ready for work labels Jan 22, 2025
@apeabody apeabody self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers triaged Scoped and ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants