Tx frame fragments (#189) #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* partially done migration to tx-frame * wip * it does not work * some fixes * fix log level * refactor write responsibility into the objects that are Writeable * fix javadoc * make classes final * refactor Writeable interface, refactor RelpWriteImpl * exit RelpWriteImpl on error * make ManualPerformanceTest work again * remove unnecessary copying of txn * Revert "remove unnecessary copying of txn" This reverts commit 19b312f. * contains broken code, but improves performance, fixes later * sync on 2024-06-03 * sync 2024-06-11 * more sync * more buffer arrays * remove obsolete TODO messages, increment PoolingDelegateTest delay * move Writable and it's Decrations to package com.teragrep.rlp_03.channel.buffer.writable; * add reporting capability for outstanding writes * add todo for read not to throw on error but just to close the connection * add outstanding() to RelpWriteFake * reading refactor * rename BufferLease isRefCountZero -> isTerminated * remove unused BufferPool argument from Leaseful implementations * fix BufferLease * refactor Supplier<FrameDelegate> into ClockFactory * Fixes javadoc issues --------- Co-authored-by: StrongestNumber9 <16169054+StrongestNumber9@users.noreply.github.com>
|
It is currently the same as #189 so no re-reviews required yet, I'll create issues from the existing comments |
Closed
14 tasks
…pEventServerClose, which did not appear in tests because payload is zero length (#200)
* implement a fix for 198 * clarify errors when NeedsReadException or NeedsWriteException interest op changes throw unexpectedly
…ement to avoid exception from logger causing lock to be left behind (#202)
* rename RelpRead to Ingress and RelpWrite to Egress * rename method relpWrite() to egress() in EstablishedContext
* re-structure networking code from rlp_03 package to net_01 package * apply spotless
* extract common client code to EstablishedContextFactory * avoid returning null on error in RelpClientFactory in case establishedContextFactory throws one * fix exception type in RelpClientFactory from RuntimeException to CompletionException
* Adds dynamic properties based RelpEventOpen version string * make version an object * rename tag -> version, as it is in the properties --------- Co-authored-by: Motoko Kusanagi <kordex@gmail.com>
* ingress interested * fix typo * move register(clock) out from EstablishedContextImpl constructor * allow Clock to re-register into a connection * add note about Clock's responsibility to read all data * add note about Clock's responsibility to read all data * fix thread safety of IngressImpl register(clock) and unregister(clock) * clarify exception messages, remove obsolete TODO * apply spotless
#213) * move com.teragrep.net_01.channel.context.frame; to com.teragrep.rlp_03.frame; * apply spotless
kortemik
requested changes
Jun 26, 2024
kortemik
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More comments in prior PR #189