Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#431: fix EmptyDataframeStep generating non-streaming dataset, add test for… #432

Merged
merged 1 commit into from
Dec 2, 2024
Merged

#431: fix EmptyDataframeStep generating non-streaming dataset, add test for… #432

merged 1 commit into from
Dec 2, 2024

Conversation

eemhu
Copy link
Contributor

@eemhu eemhu commented Nov 26, 2024

… issue#431 case

Fixes issue

Explanation:

  • When logicalStatement or any other dataset generating command is not used, EmptyDataframeStep was used to generate an empty (no results) dataset. However, the step provided a non-streaming dataset. With the changes in this PR, the step will generate a empty streaming dataset.

@eemhu eemhu requested a review from elliVM November 26, 2024 08:55
@eemhu eemhu requested a review from kortemik November 29, 2024 09:23
@kortemik kortemik merged commit 01bfd88 into teragrep:main Dec 2, 2024
1 check passed
@kortemik kortemik linked an issue Dec 2, 2024 that may be closed by this pull request
teragrep set|get config does not allow setting configuration before streaming #431
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kortemik kortemik kortemik approved these changes

@elliVM elliVM elliVM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

teragrep set|get config does not allow setting configuration before streaming
3 participants
@eemhu @kortemik @elliVM