Update converter TF version to 2.12.0 #7615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsoulanille
changed the title
mattsoulanille
changed the title
|
This is failing presubmits because tf 2.12.0 requires python>=3.8.0, and the docker container changes in this PR have not been published yet. |
mattsoulanille
changed the title
mattsoulanille
changed the title
pyu10055
reviewed
Apr 22, 2023
There was a problem hiding this comment.
Thanks Matt, interestingly the python nightly test passed with this change, since it depends on the python3_wheel target.
/~https://github.com/tensorflow/tfjs/blob/master/tfjs-converter/python/BUILD.bazel#L68
I believe this part needs to reflect the same change you made to requirements.txt
|
Good catch, @pyu10055. I've changed the dependencies listed in the BUILD target to match requirements.txt. Converter python nightly tests - Note these are using the new docker with Python 3.9. |
pyu10055
approved these changes
Apr 24, 2023
Linchenn
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tfjs-converter python dependencies to use tensorflow>=2.12.0. This is required for protobuf versions above 3.20.x. Otherwise, it throws
TypeError: Descriptors cannot not be created directly.See this stackoverflow for more details.Orbax requires at least python 3.8.0. Update the CI docker from buster to bullseye, which uses python 3.9.
Additionally, make the converter python nightly tests cloudbuild file use the release docker when running tests.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.