Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webgl] disable offscreen canvas for safari, #7436

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

pyu10055
Copy link
Collaborator

@pyu10055 pyu10055 commented Mar 2, 2023

gl fencing is not working yet for Safari technology preview, to reproduce

canvas = new OffscreenCanvas(300,300);
gl = canvas.getContext('webgl2');
sync = gl.fenceSync(gl.SYNC_GPU_COMMANDS_COMPLETE, 0);
gl.flush();
setTimeout(() => console.log(gl.clientWaitSync(sync, 0, 0)), 1000);

The status is always gl.TIMEOUT_EXPIRED, would never turn to ALREADY_SIGNED or CONDITION_SATIFIED.

fixed #7364

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Collaborator

@Linchenn Linchenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it! cc @qjia7, as Ping found, Safari meta added support of Offscreen canvas but the fencing API does not work as mentioned in the PR description.

Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pyu10055 pyu10055 merged commit 66b5673 into master Mar 3, 2023
@pyu10055 pyu10055 deleted the safari-offscreen-canvas branch March 3, 2023 19:55
@stevexbritton
Copy link

This is not fixed in the latest STP 165 released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Try Tensorflow.js!" demo does not work in MacOS Safari Technology Preview Release 163
4 participants