Propagate errors from indexedDB database.put #7322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
database.put can sometimes throw an error if the data being stored is too large. Propagate that error to the promise instead of letting it escape the callback.
|
I tried testing this by spying on indexedDB, but it returns native objects, which I can't spy on. The correct approach would be to write a mock, but that would be a lot of work. Let me know if you want me to do that. |
pyu10055
requested changes
Jan 28, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @Linchenn and @mattsoulanille)
tfjs-core/src/io/indexed_db.ts line 170 at r1 (raw file):
infoStore.put({modelPath: this.modelPath, modelArtifactsInfo}); } catch (error) { reject(error);
should it be, also for the other change
return reject(error);
|
@pyu10055 Please take a look. Thanks! |
pyu10055
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @mattsoulanille)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
database.put can sometimes throw an error if the data being stored is too large. Propagate that error to the promise instead of letting it escape the callback.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is