[Core] Fix bug with pointwise conv2d with packing #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)
tfjs-core/src/backends/webgl/webgl_ops_test.ts, line 751 at r1 (raw file):
it('pointwise conv2d optimization with odd input size', async () => { // We do special optimization in the webl backend which avoids an expensive
webgl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG
H/T to @nsthorat for identifying the core issue.
Added a unit test to reproduce the bug.
After this fix, PACKED pointwise conv2d matches CPU, however NON-PACKED still doesn't match CPU (unrelated to this bug). Thus, I added a TODO to make the newly added unit test pass for NON-PACKED pointwise.
This change is