[tfjs2keras test]: Add test against tf.keras #523
Conversation
- Previously only keras-team/keras was tested. - The --tfkeras flag enables testing against tensorflow.keras DEV
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @caisq and @davidsoergel)
integration_tests/tfjs2keras/run-test.sh, line 48 at r1 (raw file):
source "${VENV_DIR}/bin/activate" # If in Travis, use the `--user` flag when performing `pip install` of
Comment is obsolete (and I guess the --user flag is obsolete too because we're not using Travis anymore?)
There was a problem hiding this comment.
Reviewable status:
integration_tests/tfjs2keras/run-test.sh, line 48 at r1 (raw file):
Previously, davidsoergel (David Soergel) wrote…
Comment is obsolete (and I guess the
--userflag is obsolete too because we're not using Travis anymore?)
Good catch. Removed the obsolete comment.
There was a problem hiding this comment.
Thanks for the review!
Reviewable status:
There was a problem hiding this comment.
Thanks for the review!
Reviewable status:
There was a problem hiding this comment.
Thanks for the review!
Reviewable status:
Related to tensorflow/tfjs#1511
DEV
This change is