Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

Change spies to conform with window.fetch API. #434

Merged
merged 4 commits into from
Jan 25, 2019
Merged

Change spies to conform with window.fetch API. #434

merged 4 commits into from
Jan 25, 2019

Conversation

annxingyuan
Copy link
Contributor

@annxingyuan annxingyuan commented Jan 25, 2019 •
edited by nsthorat
Loading

This PR addresses tensorflow/tfjs#1140

Changes

  • Return Response within a promise in stubbed fetch so it's catch-able
  • Send content type header with fetch

This change is Reviewable

@annxingyuan annxingyuan self-assigned this Jan 25, 2019
caisq
caisq reviewed Jan 25, 2019
View reviewed changes
src/models_test.ts Outdated Show resolved Hide resolved
caisq
caisq approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@caisq caisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @annxingyuan ! But see my detailed comments below.

src/models_test.ts Outdated Show resolved Hide resolved
@annxingyuan annxingyuan merged commit 7d45bba into master Jan 25, 2019
@dsmilkov dsmilkov deleted the fetch_api_conformance branch February 21, 2019 15:38
@snyk-bot snyk-bot mentioned this pull request Dec 18, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@caisq caisq caisq approved these changes

@dsmilkov dsmilkov Awaiting requested review from dsmilkov

@nsthorat nsthorat Awaiting requested review from nsthorat

@pyu10055 pyu10055 Awaiting requested review from pyu10055

Assignees

@annxingyuan annxingyuan

Labels
BUG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annxingyuan @caisq