This repository has been archived by the owner on Oct 17, 2021. It is now read-only.
Use rollup, ship es6 in NPM, and update core version to 0.11.0. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
changed the title
nsthorat
changed the title
added 5 commits
May 15, 2018 20:02
nsthorat
pushed a commit
to tensorflow/tfjs-core
that referenced
this pull request
May 17, 2018
BREAKING "tfc" => "tf" for ES5 tf-core.js bundle users. This change does the following: - Convert to rollup for bundling. Remove browserify. - Use "extend: true" to extend a global "tf" object. There is now no "tfc". - Ship es6 in a dist-es6 folder as well as es5. - Remove models. They don't build anymore nor are they useful. We'll keep the KNN image classifier around and not unit test it just so we have the code. I'll remove this at some point in the future. This PR goes along with: tensorflow/tfjs-layers#191 tensorflow/tfjs#301 I tested with yalc across all packages, and eventually all the way to the mobilenet example in tfjs-example and everything seems to work. Using the bundles I've also used the code on the homepage to train a simple layers model (tested both union and including layers and core independently). Hosted bundles here: https://storage.googleapis.com/dljs-test/rollup/tf.js https://storage.googleapis.com/dljs-test/rollup/tf.min.js https://storage.googleapis.com/dljs-test/rollup/tf-core.js https://storage.googleapis.com/dljs-test/rollup/tf-core.min.js https://storage.googleapis.com/dljs-test/rollup/tf-layers.js https://storage.googleapis.com/dljs-test/rollup/tf-layers.min.js
nsthorat
changed the title
added 3 commits
May 17, 2018 13:24
nsthorat
changed the title
|
Review status: 0 of 9 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
nsthorat
pushed a commit
to tensorflow/tfjs
that referenced
this pull request
May 18, 2018
This change does the following: - Convert to rollup for bundling. Remove browserify. - Use "extend: true" to extend a global "tf" object. There is now no "tfc". - Ship es6 in a dist-es6 folder as well as es5. - Remove models. They don't build anymore nor are they useful. We'll keep the KNN image classifier around and not unit test it just so we have the code. I'll remove this at some point in the future. This PR goes along with: tensorflow/tfjs-layers#191 tensorflow/tfjs-core#1037 I tested with yalc across all packages, and eventually all the way to the mobilenet example in tfjs-example and everything seems to work. Using the bundles I've also used the code on the homepage to train a simple layers model (tested both union and including layers and core independently). Hosted bundles here: https://storage.googleapis.com/dljs-test/rollup/tf.js https://storage.googleapis.com/dljs-test/rollup/tf.min.js https://storage.googleapis.com/dljs-test/rollup/tf-core.js https://storage.googleapis.com/dljs-test/rollup/tf-core.min.js https://storage.googleapis.com/dljs-test/rollup/tf-layers.js https://storage.googleapis.com/dljs-test/rollup/tf-layers.min.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does the following:
This PR goes along with:
tensorflow/tfjs-core#1037
tensorflow/tfjs#301
I tested with yalc across all packages, and eventually all the way to the mobilenet example in tfjs-example and everything seems to work. Using the bundles I've also used the code on the homepage to train a simple layers model (tested both union and including layers and core independently).
Hosted bundles here:
https://storage.googleapis.com/dljs-test/rollup/tf.js
https://storage.googleapis.com/dljs-test/rollup/tf.min.js
https://storage.googleapis.com/dljs-test/rollup/tf-core.js
https://storage.googleapis.com/dljs-test/rollup/tf-core.min.js
https://storage.googleapis.com/dljs-test/rollup/tf-layers.js
https://storage.googleapis.com/dljs-test/rollup/tf-layers.min.js
This change is