Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Fix build issue where module-import code gets dropped from the bundle #987

Merged
merged 2 commits into from
Apr 24, 2018

Conversation

dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Apr 24, 2018

backend_cpu.ts and backend_webgl.ts are never included from index.ts even though there is
export {WebGLTimingInfo} from './kernels/backend_webgl';. That export is just a Typescript interface, and gets compiled away in the es5 code.

This change is Reviewable

@dsmilkov dsmilkov requested a review from nsthorat April 24, 2018 03:07
@dsmilkov dsmilkov changed the title Fix build issue where module-import code gets dropped in the bundle Fix build issue where module-import code gets dropped from the bundle Apr 24, 2018
@nsthorat
Copy link
Contributor

:lgtm_strong:


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


src/index.ts, line 18 at r1 (raw file):

 */

import './kernels/backend_webgl';

can you put a comment here saying why you need this so we don't forget and delete it?


Comments from Reviewable

@dsmilkov
Copy link
Contributor Author

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


src/index.ts, line 18 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

can you put a comment here saying why you need this so we don't forget and delete it?

Done.


Comments from Reviewable

@dsmilkov dsmilkov merged commit 3846fc0 into master Apr 24, 2018
@dsmilkov dsmilkov deleted the fix-build branch April 24, 2018 03:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants