This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
Save tensor x in forward mode when zerosLike(x) is used in backward mode #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @nkreeger and @nsthorat)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our webgl and cpu backend,
zerosLike(x)andonesLike(x)don't care ifxis disposed, because they only need its shape.In the tfjs-node backend however, calls to TF C++ kernel
zerosLike(x)requires thatxis not disposed.Because of this discrepancy, we need to call
save(x)during forward pass for all ops that usezerosLike(x)andonesLike(x)in the backwards pass.This fixes the failing integration test in tfjs-node here: https://travis-ci.org/tensorflow/tfjs-core/jobs/508508231#L893
This change is