Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Enable packed depthwiseConv for arbitrary dilation / padding. #1499

Merged
merged 43 commits into from
Jan 23, 2019

Conversation

annxingyuan
Copy link
Collaborator

@annxingyuan annxingyuan commented Jan 21, 2019

Note that no tests were added on account of #1469

This change is Reviewable

@annxingyuan annxingyuan changed the title WIP Augment depthwiseconvpacked Enable packed depthwiseConv for arbitrary dilation / padding. Jan 22, 2019
@annxingyuan annxingyuan self-assigned this Jan 22, 2019
Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)


src/kernels/webgl/conv_packed_gpu_depthwise.ts, line 55 at r1 (raw file):

    /**
     * This vectorized implementation of depthwiseConv works by gathering the

is this explanation no longer relevant? can you add another one in the new code


src/kernels/webgl/conv_packed_gpu_depthwise.ts, line 95 at r1 (raw file):

                }
              `;
            } else {

Since you have long if/else branches, add a comment on this else, here and on the other else`s

@annxingyuan annxingyuan merged commit 72ca174 into master Jan 23, 2019
@annxingyuan annxingyuan deleted the augment_depthwiseconvpacked branch January 23, 2019 00:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants