This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 950
Enable packed depthwiseConv for arbitrary dilation / padding. #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annxingyuan
changed the title
WIP Augment depthwiseconvpacked
Enable packed depthwiseConv for arbitrary dilation / padding.
Jan 22, 2019
dsmilkov
approved these changes
Jan 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)
src/kernels/webgl/conv_packed_gpu_depthwise.ts, line 55 at r1 (raw file):
/** * This vectorized implementation of depthwiseConv works by gathering the
is this explanation no longer relevant? can you add another one in the new code
src/kernels/webgl/conv_packed_gpu_depthwise.ts, line 95 at r1 (raw file):
} `; } else {
Since you have long if/else branches, add a comment on this else, here and on the other else`s
nsthorat
approved these changes
Jan 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that no tests were added on account of #1469
This change is