Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Temporarily revert aggressive uploading of packed textures. #1417

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Temporarily revert aggressive uploading of packed textures. #1417

merged 1 commit into from
Nov 29, 2018

Conversation

nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Nov 29, 2018 •
edited by dsmilkov
Loading

Fixes the test error from layers at head.

#1416

This change is Reviewable

@nsthorat nsthorat requested a review from annxingyuan November 29, 2018 15:33
@nsthorat nsthorat merged commit 4520d6c into master Nov 29, 2018
@nsthorat nsthorat deleted the packed branch November 29, 2018 16:09
@annxingyuan annxingyuan mentioned this pull request Nov 29, 2018
Merged
annxingyuan added a commit that referenced this pull request Nov 30, 2018
@annxingyuan
Properly decode data from packed textures when calling async read. (#…
546eafa 
…1419)

- Add check for `isPacked` bit on textures and call appropriate decoder in `async read`
- Revive logic for lazy uploading removed by #1417
- Add unit test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@annxingyuan annxingyuan annxingyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsthorat @annxingyuan