This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
Fix tf.pow() gradient to use power rule instead of dividing by x (which can be 0). #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
changed the title
nsthorat
changed the title
dsmilkov
approved these changes
Nov 5, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov)
nsthorat
pushed a commit
that referenced
this pull request
Jan 4, 2019
BUG #### Description <!-- Please describe the pull request here. Also, if this is an issue/bug fix, please add the issue link for reference here. --> Multiple problems with the gradient for pow were brought up in tensorflow/tfjs#346. One was fixed by #1376, the other is that the gradient with respect to the exponent is nan when the base is negative. This differs from TF which returns 0 in this case: /~https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/ops/math_grad.py#L1046 --- <!-- Please do not delete this section --> ##### For repository owners only: Please remember to apply all applicable tags to your pull request. Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY For more info see: /~https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/tensorflow/tfjs-core/1446) <!-- Reviewable:end -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is