Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Make tensor tests to pass ‘float32’ dtype argument explicitly #1254

Merged
merged 2 commits into from
Aug 29, 2018

Conversation

happyhj
Copy link
Contributor

@happyhj happyhj commented Aug 28, 2018

The goal of this PR is to fix duplicated test logic on tensor test.

  • Adds explicit float32 dtype parameter to tensor tests.
    • There were tests for default dtype and float32 dtype, but they don't passing a dtype argument so both default dtype is used.
    • If the test is for the non-default parameter (like float32), then dtype should be passed explicitly.
  • Adds dtype variation test to existing tensor tests which lack of tests for dtype variation.

For repository owners only:

Please remember to apply all applicable tags to your pull request.
Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY

For more info see: /~https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md


This change is Reviewable

@happyhj happyhj changed the title Make tensor tests to set float32 dtype explicitly Make tensor tests to pass ‘float32’ dtype explicitly Aug 28, 2018
@happyhj happyhj changed the title Make tensor tests to pass ‘float32’ dtype explicitly Make tensor tests to pass ‘float32’ dtype argument explicitly Aug 28, 2018
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

@nsthorat
Copy link
Contributor

Thanks for the cleanup and addition of tests!

@nsthorat nsthorat merged commit afbea74 into tensorflow:master Aug 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants