Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Move webgl typings to dependencies instead of devDependencies. #1185

Merged
merged 3 commits into from
Jul 25, 2018
Merged

Conversation

nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Jul 25, 2018

Currently this is breaking any typescript users (as they wont be able to find these types).


This change is Reviewable

@nsthorat nsthorat requested a review from dsmilkov July 25, 2018 18:55
Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @nsthorat and @dsmilkov)


package.json, line 55 at r1 (raw file):

    "test-all": "./scripts/test-all.sh"
  },
  "dependencies": {

move @types/seedrandom to dependencies

Nikhil Thorat added 2 commits July 25, 2018 15:30
@nsthorat nsthorat merged commit 4f2fe51 into master Jul 25, 2018
@nsthorat nsthorat deleted the types branch July 25, 2018 19:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants