This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
When disposing a kept tensor, remove it from the keep tensors array. #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the quick fix! Review status: 0 of 1 LGTMs obtained Comments from Reviewable |
|
Review status: Comments from Reviewable |
complete! 1 of 1 LGTMs obtained
|
It is my guess that this will also fix tensorflow/tfjs#438 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not removing it from the keepTensors array, we introduce a CPU memory leak which causes a very gradual linear slowdown.
Verified this fixes tensorflow/tfjs#448
This change is