-
Notifications
You must be signed in to change notification settings - Fork 950
Conversation
Add 'dist' directory to remove some TS compilation error. See microsoft/TypeScript#13656 for more info
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Just curious -- where are you seeing this error? If you run |
When you open the
There is no |
Ah got it. Actually, I think we can ignore the tsconfig in .npmignore so we don't ship it as part of the bundle -- could you add it to .npmignore instead? Thank you! |
Also the tsconfig-es5.json? |
tsconfig-es5.json shouldn't exist anymore |
Review status: complete! 1 of 1 LGTMs obtained Comments from Reviewable |
Ok so I reverted the change in the tsconfig.json and added it to .npmignore |
Thank you @HRK44 ! |
Add 'dist' directory to remove some TS compilation error.
See microsoft/TypeScript#17155 for more info
Description
For repository owners only:
Please remember to apply all applicable tags to your pull request.
Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY
For more info see: /~https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md
This change is