Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

fix: update tsconfig.json #1102

Merged
merged 6 commits into from
Jun 18, 2018
Merged

fix: update tsconfig.json #1102

merged 6 commits into from
Jun 18, 2018

Conversation

HRK44
Copy link
Contributor

@HRK44 HRK44 commented Jun 13, 2018

Add 'dist' directory to remove some TS compilation error.
See microsoft/TypeScript#17155 for more info

Description


For repository owners only:

Please remember to apply all applicable tags to your pull request.
Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY

For more info see: /~https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md


This change is Reviewable

Add 'dist' directory to remove some TS compilation error.
See microsoft/TypeScript#13656 for more info
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@HRK44
Copy link
Contributor Author

HRK44 commented Jun 13, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@nsthorat
Copy link
Contributor

Just curious -- where are you seeing this error? If you run yarn build you won't get this problem.

@HRK44
Copy link
Contributor Author

HRK44 commented Jun 18, 2018

When you open the tsconfig.json file from node_modules/@tensorflow/tfjs-core on VSCode, it underlines the whole file in red with this error :

No inputs were found in config file 'tsconfig.json'. Specified 'include' paths were '["src/"]' and 'exclude' paths were '[""]'.

There is no src folder in the bundled version, I think that's why.

screenshot from 2018-06-18 09-46-53

@nsthorat
Copy link
Contributor

Ah got it. Actually, I think we can ignore the tsconfig in .npmignore so we don't ship it as part of the bundle -- could you add it to .npmignore instead?

Thank you!

@HRK44
Copy link
Contributor Author

HRK44 commented Jun 18, 2018

Also the tsconfig-es5.json?

@nsthorat
Copy link
Contributor

tsconfig-es5.json shouldn't exist anymore

@nsthorat
Copy link
Contributor

:lgtm_strong:


Review status: :shipit: complete! 1 of 1 LGTMs obtained


Comments from Reviewable

@HRK44
Copy link
Contributor Author

HRK44 commented Jun 18, 2018

Ok so I reverted the change in the tsconfig.json and added it to .npmignore

@nsthorat nsthorat merged commit 25fc8ec into tensorflow:master Jun 18, 2018
@nsthorat
Copy link
Contributor

Thank you @HRK44 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants