-
Notifications
You must be signed in to change notification settings - Fork 950
Add a message for users running tf.js in node without the node backend #1085
Conversation
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved. src/kernels/backend_cpu.ts, line 56 at r1 (raw file):
What would this show up as in terminals that don't support unicode? Probably something like a question mark, as what I found when I tried it in non-unicode xterm. While I appreciate the lighthearted style, consider using something more robust. :) src/kernels/backend_cpu.ts, line 57 at r1 (raw file):
Grammar nit: "speech up" is transitive. Maybe say "speed things up" or "speech computation up." src/kernels/backend_cpu.ts, line 57 at r1 (raw file):
Grammar nit: add comma after "backend". src/kernels/backend_cpu.ts, line 59 at r1 (raw file):
Not only this, but also something like Also, should you say something about CUDA support? Comments from Reviewable |
Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions. src/kernels/backend_cpu.ts, line 59 at r1 (raw file): Previously, caisq (Shanqing Cai) wrote…
One idea, you can do a system call like Comments from Reviewable |
Thanks for the review. PTAL. Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions. src/kernels/backend_cpu.ts, line 56 at r1 (raw file): Previously, caisq (Shanqing Cai) wrote…
It shows up as ö, which is not bad. Non-unicode terminals are getting more rare. I think we can afford some emoji in 2018. src/kernels/backend_cpu.ts, line 57 at r1 (raw file): Previously, caisq (Shanqing Cai) wrote…
Done. src/kernels/backend_cpu.ts, line 57 at r1 (raw file): Previously, caisq (Shanqing Cai) wrote…
Done. src/kernels/backend_cpu.ts, line 59 at r1 (raw file): Previously, caisq (Shanqing Cai) wrote…
Added CUDA. I did say "and import it in the program", but I added require('.....') to be more concise. Note I didn't use import '...' since that's es6 js. require() will work on all node versions. FYI, I didn't mention tf.setBackend('tensorflow') since that is going away in a upcoming PR (the import will do that for you). Comments from Reviewable |
Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions. src/kernels/backend_cpu.ts, line 59 at r1 (raw file): Previously, dsmilkov (Daniel Smilkov) wrote…
Leave Comments from Reviewable |
Thanks! Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions. Comments from Reviewable |
Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful. src/kernels/backend_cpu.ts, line 59 at r1 (raw file): Previously, dsmilkov (Daniel Smilkov) wrote…
CUDA is Linux only and still a pain to install. Lots of Linux users don't have a CUDA-capable card - so let's not sweat that here. I think if users know about CUDA + I'd advise dropping this for now. Comments from Reviewable |
Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful. src/kernels/backend_cpu.ts, line 59 at r1 (raw file): Previously, nkreeger (Nick Kreeger) wrote…
I'll still keep the tiny plug for CUDA (in case someone has it, they should know we support it) but not going into details. People that don't know what CUDA is will either 1) ignore the "if you have CUDA" message, or 2) go google it and learn about it, which is also good Comments from Reviewable |
This PR adds a user-friendly message to remind people that we have node backend whenever they use tf.js in node with the vanilla cpu backend.
Also fixes a problem where a message saying
document is not defined
shows up at the top of the program. This was a side-effect of trying to accessdocument
when registering a WebGL backend.DOC
This change is