change the regex check for git origin #1058

pyu10055 · 2018-05-25T18:34:48Z

This change is

dsmilkov · 2018-05-25T20:52:29Z

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

tensorflow/tfjs#1058 The sign() function returns 0 on 0, which causes a division by zero in the QR decomposition function qr() if there is a zero on the diagonal. BUG

change the regex check for git origin

a8b9ec0

pyu10055 requested a review from dsmilkov May 25, 2018 18:34

dsmilkov merged commit ed06c4b into master May 28, 2018

dsmilkov deleted the relex_git_origin branch May 28, 2018 19:32

jarno-r added a commit to jarno-r/tfjs-core that referenced this pull request Jan 2, 2019

Fixed division by zero in QR decomposition. Issue tensorflow#1058

19ff52c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change the regex check for git origin #1058

change the regex check for git origin #1058

pyu10055 commented May 25, 2018 •

edited by dsmilkov

Loading

dsmilkov commented May 25, 2018

change the regex check for git origin #1058

change the regex check for git origin #1058

Conversation

pyu10055 commented May 25, 2018 • edited by dsmilkov Loading

dsmilkov commented May 25, 2018

pyu10055 commented May 25, 2018 •

edited by dsmilkov

Loading