Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Add @doc annotations to model management methods #1055

Merged
merged 1 commit into from
May 23, 2018

Conversation

caisq
Copy link
Collaborator

@caisq caisq commented May 23, 2018

  • Make them static class methods, so @doc can be applied.

DOC Add model management methods under tf.io.* to website.


This change is Reviewable

* Make them static class methods, so @doc can be applied.
@caisq caisq requested review from dsmilkov and tafsiri May 23, 2018 18:10
@tafsiri
Copy link
Contributor

tafsiri commented May 23, 2018

:lgtm_strong:

Overall looks good to me. However i wonder if you should add the new header/subheader to /~https://github.com/tensorflow/tfjs-core/blob/016b8c5085aa3e88ff32a9c087a7ee37f78d5700/src/doc.ts I had previously been under the impression that it wouldn't build if the corresponding header wasn't present in the header map. It definitely doesn't seem necessary any more, but might be nice to keep updated?


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@caisq
Copy link
Collaborator Author

caisq commented May 23, 2018

cc @nsthorat The code that @tafsiri pointed to doesn't have any of the headings and subheadings from layers. For that I'll not add Models/Management for now. But @nsthorat, please let me know if there is anything I should do related to this after this PR.


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@caisq caisq merged commit c47ec5f into tensorflow:master May 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants