Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Loss Operations: Adds hinge loss #1008

Merged
merged 4 commits into from
May 11, 2018
Merged

Conversation

manrajgrover
Copy link
Contributor

@manrajgrover manrajgrover commented Apr 29, 2018

This PR adds hinge loss to core api.


This change is Reviewable

@dsmilkov
Copy link
Contributor

dsmilkov commented May 3, 2018

Nice! One comment and we are good to go


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


src/ops/loss_ops.ts, line 130 at r1 (raw file):

        labels.shape, predictions.shape, 'Error in hingeLoss: ');

    const ones = ops.onesLike(labels);

to save memory and take advantage of broadcasting, make ones be a single scalar const ones = ops.scalar(1);


Comments from Reviewable

@manrajgrover
Copy link
Contributor Author

manrajgrover commented May 5, 2018

@dsmilkov The build failed because of some issue. Could you please restart the build?

@tafsiri
Copy link
Contributor

tafsiri commented May 8, 2018

@manrajgrover I just restarted the integration build

@dsmilkov
Copy link
Contributor

:lgtm_strong:


Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@dsmilkov dsmilkov merged commit ab91b23 into tensorflow:master May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants