fix: add overflow checking and test codes for cover edge cases #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #458 +/- ##
===========================================
+ Coverage 85.09% 85.49% +0.39%
===========================================
Files 23 23
Lines 2604 2634 +30
===========================================
+ Hits 2216 2252 +36
+ Misses 225 221 -4
+ Partials 163 161 -2
Continue to review full report at Codecov.
|
dongsam
changed the title
jaybxyz
reviewed
Oct 25, 2021
jaybxyz
reviewed
Oct 25, 2021
hallazzang
suggested changes
Oct 25, 2021
hallazzang
approved these changes
Oct 25, 2021
dongsam
changed the title
jaybxyz
approved these changes
Oct 25, 2021
4 tasks
dongsam
added a commit
that referenced
this pull request
Oct 25, 2021
* feat: add markdown link checker github workflow * feat: bump cosmos sdk to v0.44.1 * feat: bump cosmos-sdk to v0.44.2 * fix: Pool Coin Decimal Truncation During Deposit (#446) * fix: wip poc for reproduce and fix poolcoin truncation * fix: simplify calculation logic and add more tests * fix: use equality check in MintingPoolCoinsInvariant * test: fix expected value due to the change in deposit logic, expected value in test also changed * test: add test for MintingPoolCoinsInvariant * fix: update deposit truncation logic and simulation ordering * docs: update changelog and readme * fix: revert MulTruncate to Mul on Deposit Co-authored-by: Hanjun Kim <hallazzang@gmail.com> * Fix: add overflow checking and test codes for cover edge cases (#458) * test: add testcase for cover small withdrawal case * test: add test case for CreatePool * fix: refactor and optimize depleted pool validation * feat: add overflow checking logic * chore: add testcase and remove comments * test: add test code for big deposit * fix: apply PR suggestions * fix: add overflow checking logic and test cases Co-authored-by: Hanjun Kim <hallazzang@gmail.com> Co-authored-by: typark391 <86215716+typark391@users.noreply.github.com> Co-authored-by: kogisin <jaybkim2@gmail.com> Co-authored-by: Hanjun Kim <hallazzang@gmail.com> Co-authored-by: typark391 <86215716+typark391@users.noreply.github.com>
dongsam
changed the title
dongsam
added a commit
to b-harvest/liquidity
that referenced
this pull request
Jul 11, 2022
* feat: add markdown link checker github workflow 9d729d0 * Merge pull request tendermint#453 from b-harvest/kogisin/451-bump-sdk-v0.44.1 feat: bump Cosmos SDK from v0.44.0 to v0.44.1 (cherry picked from commit 9e955b0) * Merge pull request tendermint#455 from b-harvest/454-bump-sdk-v0.44.2 feat: bump cosmos-sdk to v0.44.2 (cherry picked from commit e118e21) * fix: Pool Coin Decimal Truncation During Deposit (tendermint#446) * fix: wip poc for reproduce and fix poolcoin truncation * fix: simplify calculation logic and add more tests * fix: use equality check in MintingPoolCoinsInvariant * test: fix expected value due to the change in deposit logic, expected value in test also changed * test: add test for MintingPoolCoinsInvariant * fix: update deposit truncation logic and simulation ordering * docs: update changelog and readme * fix: revert MulTruncate to Mul on Deposit Co-authored-by: Hanjun Kim <hallazzang@gmail.com> (cherry picked from commit 616985f) * Fix: add overflow checking and test codes for cover edge cases (tendermint#458) * test: add testcase for cover small withdrawal case * test: add test case for CreatePool * fix: refactor and optimize depleted pool validation * feat: add overflow checking logic * chore: add testcase and remove comments * test: add test code for big deposit * fix: apply PR suggestions * fix: add overflow checking logic and test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #457
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes