Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage relative module path #308

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

guilhem
Copy link
Contributor

@guilhem guilhem commented Sep 1, 2020

Our modules are called with:

source = "../../modules/mymodule"

and fail

Our modules are called with:
```
source = "../../modules/mymodule"
```
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #308 into master will decrease coverage by 0.40%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   59.95%   59.55%   -0.41%     
==========================================
  Files          48       48              
  Lines         984      979       -5     
==========================================
- Hits          590      583       -7     
- Misses        346      347       +1     
- Partials       48       49       +1     
Impacted Files Coverage Δ
pkg/iac-providers/terraform/v12/load-dir.go 86.04% <66.66%> (-5.63%) ⬇️

@kanchwala-yusuf kanchwala-yusuf self-assigned this Sep 2, 2020
@kanchwala-yusuf
Copy link
Contributor

@guilhem Thank you for your contribution!

@kanchwala-yusuf kanchwala-yusuf merged commit f98373b into tenable:master Sep 2, 2020
@guilhem guilhem deleted the relative_module branch September 2, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants