Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more unit tests for scan file #261

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

kanchwala-yusuf
Copy link
Contributor

@kanchwala-yusuf kanchwala-yusuf commented Aug 3, 2020

adding unit test for file scan API endpoint

@kanchwala-yusuf kanchwala-yusuf self-assigned this Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #261 into terrascan-v1.0 will increase coverage by 17.34%.
The diff coverage is 70.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           terrascan-v1.0     #261       +/-   ##
===================================================
+ Coverage           54.38%   71.72%   +17.34%     
===================================================
  Files                  20       21        +1     
  Lines                 456      474       +18     
===================================================
+ Hits                  248      340       +92     
+ Misses                186      107       -79     
- Partials               22       27        +5     
Impacted Files Coverage Δ
pkg/http-server/file-scan.go 71.15% <59.09%> (+71.15%) ⬆️
pkg/http-server/helpers.go 100.00% <100.00%> (ø)
pkg/iac-providers/terraform/v12/convert.go 75.35% <0.00%> (+24.64%) ⬆️
pkg/runtime/executor.go 88.88% <0.00%> (+44.44%) ⬆️

@kanchwala-yusuf kanchwala-yusuf merged commit a4476b1 into terrascan-v1.0 Aug 3, 2020
@kanchwala-yusuf kanchwala-yusuf deleted the terrascan-v1.0-http-unit-tests branch August 3, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant