Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bulk Transfer DLQ functionality #44

Merged
merged 8 commits into from
Feb 4, 2022
Merged

Add Bulk Transfer DLQ functionality #44

merged 8 commits into from
Feb 4, 2022

Conversation

davec643
Copy link
Contributor

Fix bug where the app crashed if the ServiceBusConnection failed

Fix bug where the app crashed if the ServiceBusConnection failed
@davec643
Copy link
Contributor Author

davec643 commented Jan 20, 2022

Upgrading to net6.0 to support ARM64 compilation
Upgraded the Avolonia packages to the latest to resolve an issue with MacOS Retina screen scaling.

Add PurgePath to the message body due to window not being big enough to read the title.
Fixed an issue with the MessageBoxes opening behind the parent when running in fullscreen on Mac
@armannaj
Copy link
Contributor

Thanks for contributing .. Sounds like a big pull request

@davec643
Copy link
Contributor Author

Thanks for contributing .. Sounds like a big pull request

@armannaj I've updated the Github workflow pipelines as well and included compiling for osx-arm64, but for some reason the files aren't tracking... The updates are in my fork if you want to try migrate them.

@armannaj
Copy link
Contributor

Thanks for contributing .. Sounds like a big pull request

@armannaj I've updated the Github workflow pipelines as well and included compiling for osx-arm64, but for some reason the files aren't tracking... The updates are in my fork if you want to try migrate them.

Approved it, Could you also look at the comments I posted above please?

@davec643
Copy link
Contributor Author

Approved it, Could you also look at the comments I posted above please?

Apologies @armannaj, this is my first time raising a PR on GitHub, where are the comments that you posted?

@armannaj
Copy link
Contributor

armannaj commented Feb 1, 2022

Approved it, Could you also look at the comments I posted above please?

Apologies @armannaj, this is my first time raising a PR on GitHub, where are the comments that you posted?

@davec643 All good mate, I hadn't submit the comments. I just did.
Also the build is failing, It's missing a package.

These are great changes and I'm keen to add them so that everyone can use it ASAP. Thanks.

@davec643
Copy link
Contributor Author

davec643 commented Feb 3, 2022

@armannaj Pushed up some changes for your comments.

As for the build, it's failing because it's trying to build using .NET Core 3.1, but the project is now .NET 6.0. I think you'll just need to merge it with the failing build before it'll compile properly -- see my forked repo for example.

@armannaj armannaj merged commit 0a089a0 into telstrapurple:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants