Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link hints have incorrect style / are illegible #32

Closed
dlh opened this issue Nov 17, 2013 · 5 comments
Closed

Link hints have incorrect style / are illegible #32

dlh opened this issue Nov 17, 2013 · 5 comments

Comments

@dlh
Copy link
Contributor

dlh commented Nov 17, 2013

Using vimari 1.9, and Safari 7.0 (9537.71) (with flash disabled).

Steps to reproduce

  1. Go to espn.com, and active link hints
  2. The link hints are illegible in many spots.

incorrect-style

Excepted result

The link hints should have a yellow background.

@guyht
Copy link
Collaborator

guyht commented Nov 18, 2013

This looks like a css issue. Maybe a clash with espn's css

@genericsteele
Copy link

Running into the same issue on the Basecamp homepage if it helps.
screen shot 2013-11-18 at 8 38 09 am

@guyht
Copy link
Collaborator

guyht commented Nov 20, 2013

Given the statistical improbability of any site on the internet using the internalVimiumHintMarker class, I think this is a safe merge 👍

Thanks for the commit!! This will be in the next release.

guyht added a commit that referenced this issue Nov 24, 2013
Fix for issue #32, “Link hints have incorrect style / are illegible”
@guyht
Copy link
Collaborator

guyht commented Nov 24, 2013

This has been fixed as part of #34

@guyht guyht closed this as completed Nov 24, 2013
@guyht
Copy link
Collaborator

guyht commented Nov 24, 2013

Fixed in v1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants