Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo wwp -> wwc #53

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix typo wwp -> wwc #53

merged 2 commits into from
Dec 12, 2023

Conversation

3nids
Copy link
Contributor

@3nids 3nids commented Dec 12, 2023

fixes #50

urskaufmann
urskaufmann reviewed Dec 12, 2023
View reviewed changes
datamodel/app/view/catchment_area/vw_catchment_area_wwp_connections.sql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all "_current" have to be replaced with "_planned" in the whole sql

@3nids 3nids requested a review from urskaufmann December 12, 2023 11:17
@3nids
Copy link
Contributor Author

3nids commented Dec 12, 2023

@urskaufmann shall we merge this?

urskaufmann
urskaufmann approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@urskaufmann urskaufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok - thanks

@3nids 3nids merged commit 84b0cce into main Dec 12, 2023
@3nids 3nids deleted the 3nids-patch-1 branch December 12, 2023 15:15
cymed added a commit to cymed/TEKSI-wastewater that referenced this pull request Aug 14, 2024
@cymed
Alter sbw_einzugsgebiet Filter (teksi#53)
8e986ad 
the changes in the sbw_einzugsgebiet view altered the geometry type to MultiSurfaces. When using ST_Dump on a ST_Multisurface that has only one part, the dump cascades through to the Exterior Ring, resulting in a CoumpoundCurve (in PostGIS 3.0.0). This PR alters the perimeter query to pass CurvePolygons regardless of the structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urskaufmann urskaufmann urskaufmann approved these changes

Assignees

@urskaufmann urskaufmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing vw_catchment_area_wwp_connections
2 participants
@3nids @urskaufmann