Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dss2020_hydraulic_load_current from 06_swmm.sql #25

Merged
merged 1 commit into from
Dec 1, 2023
Merged

remove dss2020_hydraulic_load_current from 06_swmm.sql #25

merged 1 commit into from
Dec 1, 2023

Conversation

cymed
Copy link
Contributor

@cymed cymed commented Nov 30, 2023 •
edited
Loading

use tww_od.reach.hydraulic_load_current instead

@cymed
remove dss2020_hydraulic_load_current from 06_swmm.sql
b0d5088 
use tww_od.hydraulic_load_current instead
@3nids 3nids closed this Dec 1, 2023
@3nids 3nids reopened this Dec 1, 2023
@3nids 3nids requested a review from sjib December 1, 2023 07:53
@ponceta
Copy link
Member

ponceta commented Dec 1, 2023

We have actually
tww_od.reach.hydraulic_load_current
tww_od.reach.dss2020_hydraulic_load_current
Is there a reason to have both?
If not it should be fixed in the reach class too.

@cymed
Copy link
Contributor Author

cymed commented Dec 1, 2023 •
edited
Loading

We have actually tww_od.reach.hydraulic_load_current tww_od.reach.dss2020_hydraulic_load_current Is there a reason to have both? If not it should be fixed in the reach class too.

This PR fixes it in the reach class, see source code. TBD: adaptation in swmm views. It was introduced as a workaround for swmm import because the attribute was introduced in 2020, which back at the time was not supported.

@ponceta ponceta added bug Something isn't working datamodel Concerns the datamodel labels Dec 1, 2023
@ponceta ponceta self-requested a review December 1, 2023 14:30
ponceta
ponceta approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@ponceta ponceta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix, inheritance of QGEP DSS 2020 fix not required anymore.

sjib
sjib approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@sjib sjib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok like this. Explanation from @cymed is correct.

@ponceta ponceta merged commit 81452e1 into teksi:main Dec 1, 2023
@cymed cymed deleted the remove_dss2020_hydraulic_load_current branch December 4, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjib sjib sjib approved these changes

@ponceta ponceta ponceta approved these changes

Assignees

@cymed cymed

Labels
bug Something isn't working datamodel Concerns the datamodel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cymed @ponceta @sjib @3nids