Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pioarduino platform and add proper solo1 support #452

Merged
merged 7 commits into from
Aug 12, 2024

Conversation

iranl
Copy link
Collaborator

@iranl iranl commented Aug 12, 2024

Description:

Checklist:

  • The pull request is done against the latest master branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works
  • I accept the CLA.

@iranl iranl added the enhancement New feature or request label Aug 12, 2024
@iranl iranl added this to the 9.01 milestone Aug 12, 2024
@Jason2866
Copy link

You are fast :-) You should remove the extra Ethernet lib. Arduino has its own well working one which does not have SPI conflicts as the universal Arduino Ethernet lib.

@technyon technyon merged commit 21adca0 into technyon:master Aug 12, 2024
10 checks passed
@iranl
Copy link
Collaborator Author

iranl commented Aug 12, 2024

You should remove the extra Ethernet lib. Arduino has its own well working one which does not have SPI conflicts as the universal Arduino Ethernet lib.

Fully agree, but will take some more effort to remove our dependencies on the old lib

@iranl iranl deleted the pioarduino branch August 12, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants