-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webcfg: add header and meta refresh for main page #379
Conversation
Wouldn't a async javascript call be a cleaner solution instead of forcibly refreshing the entire page every 15 seconds? |
Anything works, sure. I'll check. Would you like to keep the custom header code anyway? |
Agree, wouldn't this reset your viewport to the top of the page every 15 seconds? I'm not sure if adding javascript and async calls is really worth it, I mean the header part only display basic information that rarely changes, unless you're pairing a device. Maybe we should send the header as long as no device is paired? |
See 85e8f9c for proposal using async javascript. Updates every 3 seconds until: I do find the idea by @duhow usefull enough to implement something to tackle this as I find it annoying while pairing and/or restarting Nuki Hub that these values don't auto refresh, at least until a valid value is known. Propose async javascript is a better solution than refreshing the entire page as the viewport won't reset and it can thus be set to refresh much more often/quickly without interupting the user. |
ok sure let't go for it then. |
Co-authored-by: David Girón <contacto@duhowpi.net>
So this is ready to be merged? |
LGTM and tested without problems on my end. @duhow You ok with the current state? |
Thank you all! 😄 |
Fixed in #389 |
Adds a
meta refresh
in main/
website to reload every 15 seconds on visit.