Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect dependencies when use overrides #2178

Closed
JoshK2 opened this issue Dec 5, 2019 · 0 comments · Fixed by #2181
Closed

Incorrect dependencies when use overrides #2178

JoshK2 opened this issue Dec 5, 2019 · 0 comments · Fixed by #2181

Comments

@JoshK2
Copy link
Member

JoshK2 commented Dec 5, 2019

Describe the bug

I have a bug when using overrides feature in my project, I work with React&TypeScript so I have @types/react and @types/react-dom in my dependencies.
And I override them to be devDependencies and not dependencies, and when I run bit show on the component, I see that @types/react is now on devDependencies and dependencies, that's the bug.

Steps to Reproduce

  1. clone this repo /~https://github.com/JoshK2/overrides-bit-issue
  2. run bit show comp-a.

Screenshots, exceptions and logs

image

This is my overrides configuration:

"overrides": {
      "*": {
        "peerDependencies": {
          "react-dom": "^16.12.0"
        },
        "dependencies": {
          "@types/react": "-",
          "@types/react-dom": "-"
        },
        "devDependencies": {
          "@types/react": "^16.9.0",
          "@types/react-dom": "^16.9.0"
        }
      }
    }

Specifications

  • Bit version: 14.6.0
  • Node version: 12.7.0
  • Platform: macOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants