-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 on links to section headers that exist in the same file #250
Comments
I noticed the same thing, via MegaLinter.
and my code looks like:
To resolve this, I put
|
Extract markdown heading lines and convert to section link names, check all section links against this list and return a 404 for any that do not have a heading. Filter out code blocks because comments can be false positives for markdown headers. Make some minor adjustments for the tests to pass on Windows. Fix tcort#250 Signed-off-by: Rafael Kitover <rkitover@gmail.com>
Extract markdown heading lines and convert to section link names, check all section links against this list, first removing any code blocks, and return a 404 for any that do not have a heading. Check for `baseUrl` option prepended section links as well. Make some minor adjustments for the tests to pass on Windows. Fix tcort#250 Signed-off-by: Rafael Kitover <rkitover@gmail.com>
Same here. I've encountered the exact same issue. After conducting some tests, I believe something broke starting with version 3.12.1.(v3.12.0 is broken for me to verify the issue) Testing with version 3.11.2 yields no such problems. |
Pin to v3.11.0 in GitHub Actions workflow to avoid false positive 404 errors in CI. Refs: - tcort/markdown-link-check#250
I'm currently encountering an issue that seems to be similar across different software versions, though there appears to be some variation in the specific versions impacted. Initially, I experienced this problem with version 3.11.0. However, after some troubleshooting, version 3.11.0 is now functioning correctly for me, but I don't know why. And, the issue persists with the latest release, version 3.12.1. The problem may be consistent across these versions, albeit manifesting under slightly different conditions or configurations. |
Extract markdown heading lines and convert to section link names, check all section links against this list, first removing any code blocks, and return a 404 for any that do not have a heading. Check for `baseUrl` option prepended section links as well. Add tests for this functionality. Make some minor adjustments for the tests to pass on Windows. Fix tcort#250 Signed-off-by: Rafael Kitover <rkitover@gmail.com>
Extract markdown heading lines and convert to section link names, check all section links against this list, first removing any code blocks, and return a 404 for any that do not have a heading. Check for `baseUrl` option prepended section links as well. Add tests for this functionality. Make some minor adjustments for the tests to pass on Windows. Fix tcort#250 Signed-off-by: Rafael Kitover <rkitover@gmail.com>
I've found some strange 404 errors when running
markdown-link-check
on the attached file zng.md.Testing that file locally with
v3.11.0
, the two 404 errors are unexpected. The headers for all three of these sections look much the same in the markdown.Then if I remove a particular line from the file, the 404 errors go away.
I went to clone the repo so I could try debugging the problem myself, but oddly once I did that, I found my version installed from source didn't trigger the problem, even though the version is the same, which also struck me as odd.
The text was updated successfully, but these errors were encountered: