perf(job-scheduler): add delayed job and scheduler in same script #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
changed the title
roggervalf
commented
Jan 5, 2025
| tz: repeatOpts.tz, | ||
| pattern, | ||
| every, | ||
| return this.trace<Job<T, R, N>>( |
There was a problem hiding this comment.
copied for now, when update job scheduler get refactored, we will reuse same wrapper
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
## [5.34.7](v5.34.6...v5.34.7) (2025-01-06) ### Performance Improvements * **job-scheduler:** add delayed job and scheduler in same script ([#2993](#2993)) ([95718e8](95718e8))
manast
reviewed
Jan 7, 2025
| @@ -0,0 +1,25 @@ | |||
| --[[ | |||
| Add marker if needed when a job is available. | |||
There was a problem hiding this comment.
The comment here seems to be wrong.
There was a problem hiding this comment.
addressed in #2997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Enter your explanation here.
Why is this change necessary? In order to handle addition of a job scheduler and delayed job in same script. Be able to execute in serverless redis as we don't need to use multi
How
Enter the implementation details here.
How did you implement this? Add a new include to handle delayed job additions
Additional Notes (Optional)
Any extra info here.