Discard invalid declarations when parsing CSS #16093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
fix/discard-invalid-decls
branch
from
a92ff26 to
5ba4703
Compare
Comment on lines
+332
to
+353
| it('should parse a custom property with an empty value', () => { | ||
| expect(parse('--foo:;')).toEqual([ | ||
| { | ||
| kind: 'declaration', | ||
| property: '--foo', | ||
| value: '', | ||
| important: false, | ||
| }, | ||
| ]) | ||
| }) | ||
|
|
||
| it('should parse a custom property with a space value', () => { | ||
| expect(parse('--foo: ;')).toEqual([ | ||
| { | ||
| kind: 'declaration', | ||
| property: '--foo', | ||
| value: '', | ||
| important: false, | ||
| }, | ||
| ]) | ||
| }) | ||
|
|
There was a problem hiding this comment.
Added these just in case we broke something with unexpected semicolon detection
| }) | ||
|
|
||
| it('should error when consecutive semicolons exist', () => { | ||
| expect(() => parse(';;;')).toThrowErrorMatchingInlineSnapshot(`[Error: Unexpected: \`;;;\`]`) |
There was a problem hiding this comment.
We could also just throw the same Unexpected semicolon error, I'm indifferent on this one.
I think once we have proper span/location, we could highlight the full ;;; section.
There was a problem hiding this comment.
I was thinking about this but I think the error is fine as is
RobinMalfait
force-pushed
the
fix/discard-invalid-decls
branch
from
5ba4703 to
0309756
Compare
thecrypticace
commented
Jan 31, 2025
thecrypticace
commented
Jan 31, 2025
RobinMalfait
force-pushed
the
fix/discard-invalid-decls
branch
from
459f274 to
ddf7dfb
Compare
Let's us some early returns and simplify some error messages.
RobinMalfait
force-pushed
the
fix/discard-invalid-decls
branch
from
ddf7dfb to
7d8c054
Compare
|
Can't approve the PR since I opened it originally lol but LGTM 👍 |
RobinMalfait
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this when triaging an error someone had on Tailwind Play.
;we often assume a valid declaration precedes it but that may not be the caseThis PR fixes all three of these by ignoring these invalid cases. Though some should probably be turned into errors.