Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid as remaining fields in the middle of the struct #697

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

Gusarich
Copy link
Member

Closes #688

  • I have updated CHANGELOG.md
  • I have documented my contribution in Tact Docs: /~https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.5.0 milestone Aug 16, 2024
@Gusarich Gusarich requested a review from anton-trunov August 16, 2024 06:33
@anton-trunov anton-trunov modified the milestones: v1.5.0, v1.4.4 Aug 16, 2024
@anton-trunov anton-trunov self-assigned this Aug 16, 2024
@Gusarich Gusarich requested a review from anton-trunov August 16, 2024 10:30
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff

@anton-trunov anton-trunov merged commit a07f9d6 into tact-lang:main Aug 16, 2024
3 checks passed
@anton-trunov anton-trunov changed the title Forbid remainder fields in the middle of the struct Forbid as remaining fields in the middle of the struct Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only allow as remaining annotation for last fields of message declarations
2 participants