Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover message parsing via .fromCell and .fromSlice with tests #454

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Cover message parsing via .fromCell and .fromSlice with tests #454

merged 3 commits into from
Jun 21, 2024

Conversation

Gusarich
Copy link
Member

Closes #453

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.4.0 milestone Jun 21, 2024
@Gusarich Gusarich requested a review from anton-trunov June 21, 2024 12:39
@anton-trunov anton-trunov self-assigned this Jun 21, 2024
novusnota
novusnota reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add more types to tests, like String, Bool and, say, StringBuilder (that one is rarely used as a Struct field, but just in case)?

@anton-trunov
Copy link
Member

Sorry, there are merge conflicts from #445 now

anton-trunov
anton-trunov reviewed Jun 21, 2024
View reviewed changes
@Gusarich
Copy link
Member Author

@anton-trunov done

@anton-trunov
Copy link
Member

Could you please add more types to tests, like String, Bool and, say, StringBuilder (that one is rarely used as a Struct field, but just in case)?

Let's open a new issue on this, maybe with even a broader scope? If there are any bugs in this, we'll release v1.4.1 :)

@anton-trunov anton-trunov merged commit fecb9d5 into tact-lang:main Jun 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novusnota novusnota novusnota left review comments

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Message parsing via .fromCell and .fromSlice is not tested
3 participants
@Gusarich @anton-trunov @novusnota