Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wrappers): generate constants in wrappers #2043

Merged
merged 10 commits into from
Feb 26, 2025

Conversation

i582
Copy link
Contributor

@i582 i582 commented Feb 26, 2025

Issue

Closes #2032.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 requested a review from a team as a code owner February 26, 2025 16:15
verytactical
verytactical previously approved these changes Feb 26, 2025
@verytactical
Copy link
Contributor

Extending the writeTypescript interface is a really sad thing to do. I wish we could keep it at just the ABI.

@i582 i582 added this to the v1.6.0 milestone Feb 26, 2025
novusnota
novusnota previously approved these changes Feb 26, 2025
@i582 i582 dismissed stale reviews from novusnota and verytactical via af9913c February 26, 2025 18:25
@verytactical verytactical merged commit a5e73a1 into main Feb 26, 2025
23 of 24 checks passed
@verytactical verytactical deleted the pmakhnev/constants-in-wrappers branch February 26, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put constants in the TypeScript wrappers
4 participants