Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show internal error for unknown types for variables #2005

Merged
merged 6 commits into from
Feb 25, 2025

Conversation

i582
Copy link
Contributor

@i582 i582 commented Feb 25, 2025

Issue

Closes #2003.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 requested a review from a team as a code owner February 25, 2025 14:34
@novusnota novusnota added this to the v1.6.0 milestone Feb 25, 2025
novusnota
novusnota previously approved these changes Feb 25, 2025
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 ______
( LGTM )
 ¯¯¯¯¯¯
    o
     o
                                   .::!!!!!!!:.
  .!!!!!:.                        .:!!!!!!!!!!!!
  ~~~~!!!!!!.                 .:!!!!!!!!!UWWW$$$ 
      :$$NWX!!:           .:!!!!!!XUWW$$$$$$$$$P 
      $$$$$##WX!:      .<!!!!UW$$$$"  $$$$$$$$# 
      $$$$$  $$$UX   :!!UW$$$$$$$$$   4$$$$$* 
      ^$$$B  $$$$\     $$$$$$$$$$$$   d$$R" 
        "*$bd$$$$      '*$$$$$$$$$$$o+#" 
             """"          """""""

@anton-trunov anton-trunov self-assigned this Feb 25, 2025
@anton-trunov anton-trunov merged commit ee9a479 into main Feb 25, 2025
26 checks passed
@anton-trunov anton-trunov deleted the pmakhnev/fix-internal-error-for-unknown-types branch February 25, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal compiler error for unknown type in variable type hint
3 participants