Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: runtime sha256 now works for arbitrary strings with length >= 128 #1626

Merged
merged 20 commits into from
Feb 5, 2025
Merged

fix: runtime sha256 now works for arbitrary strings with length >= 128 #1626

merged 20 commits into from
Feb 5, 2025

Conversation

i582
Copy link
Contributor

@i582 i582 commented Jan 29, 2025 •
edited
Loading

Issue

Closes #1056.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 added this to the v1.6.0 milestone Jan 29, 2025
@i582 i582 requested a review from a team as a code owner January 29, 2025 08:47
@anton-trunov
Copy link
Member

Let's resolve merge conflicts here

@i582 i582 requested a review from anton-trunov February 3, 2025 07:27
@anton-trunov anton-trunov changed the title fix: runtime sha256 now work for arbitrary strings with length >= 128 fix: runtime sha256 now works for arbitrary strings with length >= 128 Feb 4, 2025
anton-trunov
anton-trunov reviewed Feb 4, 2025
View reviewed changes
src/stdlib/stdlib/stdlib_ex.fc Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shvandre take a look at this code please

@anton-trunov anton-trunov self-assigned this Feb 4, 2025
anton-trunov
anton-trunov requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflicts

@i582 i582 requested a review from anton-trunov February 4, 2025 09:19
@i582 i582 requested a review from verytactical February 4, 2025 11:59
@anton-trunov anton-trunov merged commit 4ef078c into main Feb 5, 2025
24 checks passed
@anton-trunov anton-trunov deleted the pmakhnev/sha256_for_long_strings branch February 5, 2025 10:30
sansx pushed a commit to TownSquareXYZ/tact that referenced this pull request Feb 10, 2025
@i582 @sansx
fix: runtime sha256 works for arbitrary strings with length >= 128 (t…
b95522e 
…act-lang#1626)
@novusnota novusnota mentioned this pull request Feb 13, 2025
Merged
3 tasks
This was referenced Feb 20, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

@verytactical verytactical verytactical approved these changes

@Shvandre Shvandre Awaiting requested review from Shvandre

@novusnota novusnota Awaiting requested review from novusnota

@Gusarich Gusarich Awaiting requested review from Gusarich

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Runtime sha256 should work for arbitrary strings even with length >= 128
4 participants
@i582 @anton-trunov @novusnota @verytactical