Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various bugs in traits #1591

Merged
merged 22 commits into from
Feb 5, 2025
Merged

fix: various bugs in traits #1591

merged 22 commits into from
Feb 5, 2025

Conversation

i582
Copy link
Contributor

@i582 i582 commented Jan 27, 2025 •
edited
Loading

Issue

Closes #1291.
Closes #1631.
Closes #1713.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 added this to the v1.6.0 milestone Jan 27, 2025
@i582 i582 requested a review from a team as a code owner January 27, 2025 12:10
@i582 i582 changed the title fix: support overriding constant and methods of BaseTrait fix: support overriding constants and methods of BaseTrait Jan 27, 2025
@i582 i582 requested a review from novusnota February 4, 2025 10:31
@i582 i582 changed the title fix: support overriding constants and methods of BaseTrait fix: various bugs in the implementation of traits Feb 5, 2025
@i582 i582 requested a review from anton-trunov February 5, 2025 12:06
@anton-trunov anton-trunov changed the title fix: various bugs in the implementation of traits fix: various bugs in traits Feb 5, 2025
anton-trunov
anton-trunov reviewed Feb 5, 2025
View reviewed changes
novusnota
novusnota approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YTGZ

@anton-trunov anton-trunov self-assigned this Feb 5, 2025
@anton-trunov anton-trunov merged commit f853782 into main Feb 5, 2025
26 checks passed
@anton-trunov anton-trunov deleted the pmakhnev/constants-override-in-traits branch February 5, 2025 18:10
sansx pushed a commit to TownSquareXYZ/tact that referenced this pull request Feb 10, 2025
@i582 @sansx
fix: various bugs with constants and BaseTrait inheritance in traits (t…
674e8f1 
…act-lang#1591)

* fix: support overriding constant and methods of BaseTrait

* fix: forbid traits inherit implicitly from BaseTrait

* fix: check that the overridden constant has a super constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov requested changes

@novusnota novusnota novusnota approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
3 participants
@i582 @anton-trunov @novusnota