fix: forbid read and write to `self` in contract `init` function #1482

i582 · 2025-01-22T07:10:45Z

Issue

Closes #816.

Checklist

I have updated CHANGELOG.md
I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
I have run all the tests locally and no test failure was reported
I have run the linter, formatter and spellchecker
I did not do unrelated and/or undiscussed refactorings

Fixes #816

src/types/resolveErrors.ts

src/types/test-failed/read-self-in-init-function-assign.tact

src/types/test-failed/init-self-reassign.tact

src/ast/iterators.ts

jeshecdom

The main unresolved issue here is if we should change the signature of the traverse function. I say, we keep traverse as it was before, but add a new traverseAndCheck that receives a callback that returns boolean. Comments below.

Let us do this and merge this PR.

src/ast/iterators.ts

src/types/resolveDescriptors.ts

src/types/resolveErrors.ts

src/types/resolveDescriptors.ts

…t-lang#1482) * fix: forbid read and write to `self` in contract `init` function Fixes tact-lang#816 * added one more test * added CHANGELOG.md entry * fixed review issues * fixed review issue * fix * removed old code

i582 added 2 commits January 22, 2025 11:06

fix: forbid read and write to self in contract init function

3b88674

Fixes #816

added one more test

60b1fc6

i582 added this to the v1.6.0 milestone Jan 22, 2025

i582 requested a review from a team as a code owner January 22, 2025 07:10

added CHANGELOG.md entry

b8b709a

i582 requested a review from anton-trunov January 22, 2025 17:00

Merge branch 'main' into pmakhnev/forbid-whole-self-read-and-write

436546f

verytactical reviewed Jan 22, 2025

View reviewed changes

src/types/resolveErrors.ts Outdated Show resolved Hide resolved

jeshecdom reviewed Jan 22, 2025

View reviewed changes

src/types/test-failed/read-self-in-init-function-assign.tact Show resolved Hide resolved

src/types/test-failed/init-self-reassign.tact Show resolved Hide resolved

src/ast/iterators.ts Outdated Show resolved Hide resolved

fixed review issues

094d1d1

anton-trunov requested a review from jeshecdom January 22, 2025 19:37

i582 added 2 commits January 23, 2025 11:27

Merge branch 'main' into pmakhnev/forbid-whole-self-read-and-write

7edfafd

Merge branch 'main' into pmakhnev/forbid-whole-self-read-and-write

1d30c40

anton-trunov self-assigned this Jan 24, 2025

Merge branch 'main' into pmakhnev/forbid-whole-self-read-and-write

45f6f92

jeshecdom reviewed Jan 27, 2025

View reviewed changes

src/ast/iterators.ts Outdated Show resolved Hide resolved

src/types/resolveDescriptors.ts Outdated Show resolved Hide resolved

src/types/resolveErrors.ts Outdated Show resolved Hide resolved

src/types/resolveDescriptors.ts Outdated Show resolved Hide resolved

i582 added 3 commits January 27, 2025 12:27

fixed review issue

ccca6c1

fix

cf0a07a

removed old code

43df3ca

i582 requested a review from jeshecdom January 27, 2025 08:33

jeshecdom approved these changes Jan 27, 2025

View reviewed changes

jeshecdom merged commit db3974e into main Jan 27, 2025
23 checks passed

jeshecdom deleted the pmakhnev/forbid-whole-self-read-and-write branch January 27, 2025 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: forbid read and write to `self` in contract `init` function #1482

fix: forbid read and write to `self` in contract `init` function #1482

i582 commented Jan 22, 2025 •

edited

Loading

jeshecdom left a comment

fix: forbid read and write to self in contract init function #1482

fix: forbid read and write to self in contract init function #1482

Conversation

i582 commented Jan 22, 2025 • edited Loading

Issue

Checklist

jeshecdom left a comment

Choose a reason for hiding this comment

fix: forbid read and write to `self` in contract `init` function #1482

fix: forbid read and write to `self` in contract `init` function #1482

i582 commented Jan 22, 2025 •

edited

Loading