Added unpublish action and moved set property from editable user forms #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $fields = parent::getCMSFields(); | ||
|
|
||
| $fields->addFieldsToTab('Root.Main', array( | ||
| TextField::create('Property', 'Property')->setRightTitle('Property to set; if this exists as a setter method, will be called passing the value'), |
There was a problem hiding this comment.
Can this be changed to use _t() for "Property to set" ?
There was a problem hiding this comment.
Should I also change this to be have "Workflow" before Action in the class/file names?
There was a problem hiding this comment.
Sure why not - stops any backwards compat issues with editable user forms then too :)
|
Commits updated per notes. |
nyeholt
pushed a commit
that referenced
this pull request
Dec 23, 2015
|
Need a couple more changes, have merged this manually in a separate push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests pending