Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Unit Tests #21

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Clean Up Unit Tests #21

merged 2 commits into from
Jun 16, 2021

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Jun 16, 2021

Create temporary files outside of working directory for tests that create/modify SIFs. Remove SIF file that was accidentally checked in. Simplify .gitignore.

Fixes #18

@tri-adam tri-adam self-assigned this Jun 16, 2021
@tri-adam tri-adam marked this pull request as ready for review June 16, 2021 01:14
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tri-adam tri-adam merged commit 4373c51 into sylabs:master Jun 16, 2021
@tri-adam tri-adam deleted the clean-unit-tests branch June 16, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Tests Modify Working Directory
2 participants