Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make incompatible version message more clear #2377

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

sxyazi
Copy link
Owner

@sxyazi sxyazi commented Feb 21, 2025

No description provided.

@sxyazi sxyazi merged commit 52a5ab5 into main Feb 21, 2025
6 checks passed
@sxyazi sxyazi deleted the pr-8b932b65 branch February 21, 2025 15:08
@bczhc
Copy link

bczhc commented Feb 24, 2025

Interestingly this changes graphics adapter detection behavior. E.g. on the same terminal, I have this result:

48f0860
Yazi
    Version: 25.2.11 (7f17ecd5 2025-02-24)
    Debug  : true
    Triple : x86_64-unknown-linux-gnu (linux-x86_64)
    Rustc  : 1.84.1 (e71f9a9a 2025-01-27)

Ya
    Version: 25.2.11 (Arch Linux 2025-02-16)

Emulator
    TERM                : Some("xterm-256color")
    TERM_PROGRAM        : None
    TERM_PROGRAM_VERSION: None
    Brand.from_env      : Some(Alacritty)
    Emulator.detect     : Emulator { kind: Left(Alacritty), light: false, cell_size: None }

Adapter
    Adapter.matches: X11

Desktop
    XDG_SESSION_TYPE           : Some("tty")
    WAYLAND_DISPLAY            : None
    DISPLAY                    : Some(":0")
    SWAYSOCK                   : None
    HYPRLAND_INSTANCE_SIGNATURE: None
    WAYFIRE_SOCKET             : None

SSH
    shared.in_ssh_connection: false

WSL
    WSL: false

Variables
    SHELL           : Some("/bin/zsh")
    EDITOR          : Some("vim")
    VISUAL          : None
    YAZI_FILE_ONE   : None
    YAZI_CONFIG_HOME: None
    YAZI_ZOXIDE_OPTS: None
    FZF_DEFAULT_OPTS: None

Text Opener
    default     : Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block-create: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block-rename: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : false
    tmux version       : tmux 3.5a
    tmux build flags   : enable-sixel=Unknown
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file          : 5.46
    ueberzugpp    : No such file or directory (os error 2)
    ffmpeg/ffprobe: 7.1 / 7.1
    pdftoppm      : 25.01.0
    magick        : 7.1.1-43
    fzf           : 0.57.0
    fd/fdfind     : 10.2.0 / No such file or directory (os error 2)
    rg            : 13.0.0
    chafa         : 1.14.5
    zoxide        : 0.9.6
    7zz/7z        : No such file or directory (os error 2) / 24.09
    jq            : 1.7.1

Clipboard
    wl-copy/paste: No such file or directory (os error 2) / No such file or directory (os error 2)
    xclip        : 0.13
    xsel         : 1.2.1


See https://yazi-rs.github.io/docs/plugins/overview#debugging on how to enable logging or debug runtime errors.

48f0860~1
Yazi
    Version: 25.2.11 (52a5ab59 2025-02-24)
    Debug  : true
    Triple : x86_64-unknown-linux-gnu (linux-x86_64)
    Rustc  : 1.84.1 (e71f9a9a 2025-01-27)

Ya
    Version: 25.2.11 (Arch Linux 2025-02-16)

Emulator
    TERM                : Some("xterm-256color")
    TERM_PROGRAM        : None
    TERM_PROGRAM_VERSION: None
    Brand.from_env      : None
    Emulator.detect     : Emulator { kind: Right(Unknown { kgp: false, sixel: true }), light: false, cell_size: None }

Adapter
    Adapter.matches: Sixel

Desktop
    XDG_SESSION_TYPE           : Some("tty")
    WAYLAND_DISPLAY            : None
    DISPLAY                    : Some(":0")
    SWAYSOCK                   : None
    HYPRLAND_INSTANCE_SIGNATURE: None
    WAYFIRE_SOCKET             : None

SSH
    shared.in_ssh_connection: false

WSL
    WSL: false

Variables
    SHELL           : Some("/bin/zsh")
    EDITOR          : Some("vim")
    VISUAL          : None
    YAZI_FILE_ONE   : None
    YAZI_CONFIG_HOME: None
    YAZI_ZOXIDE_OPTS: None
    FZF_DEFAULT_OPTS: None

Text Opener
    default     : Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block-create: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block-rename: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : false
    tmux version       : tmux 3.5a
    tmux build flags   : enable-sixel=Unknown
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file          : 5.46
    ueberzugpp    : No such file or directory (os error 2)
    ffmpeg/ffprobe: 7.1 / 7.1
    pdftoppm      : 25.01.0
    magick        : 7.1.1-43
    fzf           : 0.57.0
    fd/fdfind     : 10.2.0 / No such file or directory (os error 2)
    rg            : 13.0.0
    chafa         : 1.14.5
    zoxide        : 0.9.6
    7zz/7z        : No such file or directory (os error 2) / 24.09
    jq            : 1.7.1

Clipboard
    wl-copy/paste: No such file or directory (os error 2) / No such file or directory (os error 2)
    xclip        : 0.13
    xsel         : 1.2.1


See https://yazi-rs.github.io/docs/plugins/overview#debugging on how to enable logging or debug runtime errors.

Diff:

--- old	2025-02-25 02:08:45.439131204 +0800
+++ new	2025-02-25 02:09:04.209366474 +0800
@@ -1,6 +1,6 @@
 
 Yazi
-    Version: 25.2.11 (7f17ecd5 2025-02-24)
+    Version: 25.2.11 (52a5ab59 2025-02-24)
     Debug  : true
     Triple : x86_64-unknown-linux-gnu (linux-x86_64)
     Rustc  : 1.84.1 (e71f9a9a 2025-01-27)
@@ -12,11 +12,11 @@
     TERM                : Some("xterm-256color")
     TERM_PROGRAM        : None
     TERM_PROGRAM_VERSION: None
-    Brand.from_env      : Some(Alacritty)
-    Emulator.detect     : Emulator { kind: Left(Alacritty), light: false, cell_size: None }
+    Brand.from_env      : None
+    Emulator.detect     : Emulator { kind: Right(Unknown { kgp: false, sixel: true }), light: false, cell_size: None }
 
 Adapter
-    Adapter.matches: X11
+    Adapter.matches: Sixel
 
 Desktop
     XDG_SESSION_TYPE           : Some("tty")

@sxyazi
Copy link
Owner Author

sxyazi commented Feb 24, 2025

This PR adds support for the Alacritty Sixel fork. When Yazi detects your Alacritty supports Sixel, it will automatically enable it, see #2374

@bczhc
Copy link

bczhc commented Feb 24, 2025

Yes I'm currently and exactly using Alacritty with Sixel patch. With a previous version (0.4.xx) yazi had been showing image preview well until today I did a system update. With the latest yazi (v25.2.11 2025-02-16) in Arch repository, the image preview was broken somehow (shows X11 adapter). And this PR fixed it again on time. That's good and thanks.

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Feb 27, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [sxyazi/yazi](/~https://github.com/sxyazi/yazi) | patch | `v25.2.11` -> `v25.2.26` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>sxyazi/yazi (sxyazi/yazi)</summary>

### [`v25.2.26`](/~https://github.com/sxyazi/yazi/releases/tag/v25.2.26)

[Compare Source](sxyazi/yazi@v25.2.11...v25.2.26)

#### Breaking Changes

-   `separator_open` and `separator_close` have been replaced with the new `sep_left` and `sep_right`. sxyazi/yazi#2313
-   The `[completion]` component has been renamed to `[cmp]`. sxyazi/yazi#2399

#### Deprecated

-   `MANAGER`, `PREVIEW`, `PLUGIN`, and `THEME` have been deprecated in favor of the new `rt` and `th`. sxyazi/yazi#2389
-   `ya.manager_emit()` has been deprecated in favor of the new `ya.mgr_emit()`. sxyazi/yazi#2397

#### Built-in Previewer Improvements

-   The JSON previewer will now respect the user's `wrap` setting to support automatic JSON line wrapping. sxyazi/yazi#2337, thanks [@&#8203;boydaihungst](/~https://github.com/boydaihungst)
-   The PDF previewer will now respect the user's `max_width` setting to address the issue of previewing content that is too small. sxyazi/yazi#2331
-   The ImageMagick previewer will now respect the user's `image_alloc` setting to limit memory usage. sxyazi/yazi#2403

#### New Search Engine: [`rga`](/~https://github.com/phiresky/ripgrep-all)

sxyazi/yazi#2383 (thanks [@&#8203;paperbenni](/~https://github.com/paperbenni)) has added a new [`ripgrep-all`](/~https://github.com/phiresky/ripgrep-all) search engine.

It is a wrapper around `ripgrep` that supports additional file formats (such as PDF, docx, epub, etc.).

You can use it with the `search --via=rga` command.

#### Allow to Specify Layer for Keymap Commands

With sxyazi/yazi#2399, you'll now be able to assign commands from different layers to a keybinding in `keymap.toml`.

This opens up the possibility of interacting with any other component, such as accessing commands from the manager (`[manager]`) within the input component (`[input]`):

```toml
[[input.prepend_keymap]]
on   = "<Esc>"
run  = [ "close", "mgr:escape --filter" ]
desc = "Close input and cancel the filter"
```

When you press `Esc` in the input box to exit the filter view (triggered by the `f` key), the filter will be canceled as the input is closed.

#### More Flexible Status Bar Customization

sxyazi/yazi#2313 (thanks [@&#8203;PFiS1737](/~https://github.com/PFiS1737)) introduces `sep_left` and `sep_right` to replace the previous `separator_open` and `separator_close` settings, allowing different separators to be set for the left and right sides:

![status-sep-explain](/~https://github.com/user-attachments/assets/fd61a85d-9823-46d6-a01f-56c99155c630)

#### Support for Setting Spotter Table Styles

sxyazi/yazi#2391 introduces two new settings, `tbl_col` and `tbl_cell`, in `theme.toml` to configure the styles for spotter table columns and cells, respectively.

<img src="/~https://github.com/user-attachments/assets/f2167e58-96c3-4a66-a244-1150e3e80e43" height="400" />

#### What's Changed
* feat!: allow different separators to be applied individually to the left and right sides of the status bar by @&#8203;PFiS1737 in sxyazi/yazi#2313
* fix: load mount points with the best effort even if the `/dev/disk/by-label` directory does not exist by @&#8203;sxyazi in sxyazi/yazi#2326
* feat: CSI-based Vim and Neovim built-in terminal detection for better accuracy by @&#8203;sxyazi in sxyazi/yazi#2327
* feat: respect the user's `max_width` setting for the built-in PDF preloader by @&#8203;sxyazi in sxyazi/yazi#2331
* feat: respect the user's `wrap` setting for the built-in JSON previewer by @&#8203;boydaihungst in sxyazi/yazi#2337
* refactor: consistent naming for enum variants by @&#8203;sxyazi in sxyazi/yazi#2339
* feat: new `external` and `removable` fields in the `fs.partitions()` API by @&#8203;sxyazi in sxyazi/yazi#2343
* feat: terminal response detection under async stdin by @&#8203;sxyazi in sxyazi/yazi#2347
* fix: incorrect kebab-case for the notify level enum by @&#8203;hankertrix in sxyazi/yazi#2349
* fix: add maximum preview limit under `/proc` virtual file system by @&#8203;sxyazi in sxyazi/yazi#2355
* feat: add a link to the debugging instructions in `yazi --debug` by @&#8203;sxyazi in sxyazi/yazi#2365
* fix: didn't reset previous `Cha` when loading directories in chunks by @&#8203;sxyazi in sxyazi/yazi#2366
* feat: make incompatible version message more clear by @&#8203;sxyazi in sxyazi/yazi#2377
* feat: bump `trash` and `libc` versions to support NetBSD by @&#8203;sxyazi in sxyazi/yazi#2388
* feat: new `rt` and `th` allow to access user configuration and theme scheme in sync/async plugins consistently by @&#8203;sxyazi in sxyazi/yazi#2389
* feat: new `tbl_col` and `tbl_cell` in theme system for spotter table styling by @&#8203;sxyazi in sxyazi/yazi#2391
* feat: add ripgrep-all support for search by @&#8203;paperbenni in sxyazi/yazi#2383
* feat: new `cf.args` to access startup arguments by @&#8203;sxyazi in sxyazi/yazi#2392
* refactor: rename `cf` to `rt` by @&#8203;sxyazi in sxyazi/yazi#2393
* feat: expose `mode` field in `Cha` by @&#8203;sxyazi in sxyazi/yazi#2394
* refactor: rename `rt.manager` to `rt.mgr`, and `th.manager` to `th.mgr` by @&#8203;sxyazi in sxyazi/yazi#2397
* feat!: allow to specify layer for keymap commands by @&#8203;sxyazi in sxyazi/yazi#2399

#### New Contributors
* @&#8203;PFiS1737 made their first contribution in sxyazi/yazi#2313
* @&#8203;paperbenni made their first contribution in sxyazi/yazi#2383

**Full Changelog**: sxyazi/yazi@v25.2.11...v25.2.26

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](/~https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODEuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE4MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants