Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPStan #961

Merged
merged 11 commits into from
Feb 26, 2024
Merged

Add PHPStan #961

merged 11 commits into from
Feb 26, 2024

Conversation

swissspidy
Copy link
Owner

@swissspidy swissspidy commented Feb 26, 2024

Working towards higher levels

@swissspidy swissspidy added this to the 2.2.2 milestone Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 64.86486% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 94.07%. Comparing base (12e97ae) to head (eeeee28).
Report is 6 commits behind head on main.

Files Patch % Lines
inc/functions.php 64.86% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   95.42%   94.07%   -1.36%     
==========================================
  Files           5        5              
  Lines         612      641      +29     
  Branches       39       39              
==========================================
+ Hits          584      603      +19     
- Misses         28       38      +10     
Flag Coverage Δ
default 91.79% <64.86%> (-1.76%) ⬇️
js 100.00% <ø> (ø)
multisite 91.79% <64.86%> (-1.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

build-cs/composer.json Outdated Show resolved Hide resolved
@swissspidy swissspidy merged commit 58f299f into main Feb 26, 2024
15 of 17 checks passed
@swissspidy swissspidy deleted the add/phpstan branch February 26, 2024 15:08
@szepeviktor
Copy link
Contributor

szepeviktor commented Feb 26, 2024

So sad to see low level code (HTTP request processing) mixed with high level code (language selection).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants