Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implode error #590

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Fix implode error #590

merged 3 commits into from
Jan 11, 2023

Conversation

akirk
Copy link
Contributor

@akirk akirk commented Jan 10, 2023

Without this patch, on the Site Health page you get this error:

 Warning: implode(): Invalid arguments passed in wp-content/plugins/preferred-languages/inc/functions.php on line 999

because preferred_languages_get_user_list() can return an array or false and you cannot implode( ',', false ).

Screenshot 2023-01-10 at 22 28 46

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #590 (9df8ac3) into main (f518e3e) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9df8ac3 differs from pull request most recent head 66b0b1a. Consider uploading reports for the commit 66b0b1a to get more accurate results

@@           Coverage Diff           @@
##             main     #590   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files           5        5           
  Lines         556      556           
  Branches       31       31           
=======================================
  Hits          539      539           
  Misses         17       17           
Flag Coverage Δ
default 88.38% <100.00%> (ø)
js 100.00% <ø> (ø)
multisite 92.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
inc/functions.php 95.70% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@swissspidy swissspidy enabled auto-merge (squash) January 11, 2023 11:08
@swissspidy swissspidy merged commit f971f1f into swissspidy:main Jan 11, 2023
@swissspidy
Copy link
Owner

Thanks @akirk!

@swissspidy swissspidy added this to the 2.0.0 milestone Jan 11, 2023
@akirk akirk deleted the patch-1 branch January 11, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants