-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow php 8 #6
Allow php 8 #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @holtkamp! However, I'd like to keep PHP 7.0 as minimum required version for now. Also don't forget to update CI config (.travis.yml and .scrutinizer.yml) to run tests on all supported PHP versions.
I am afraid 7.2 will be the minimum since PHPUnit requires / allows this and higher versions (required for PHP 8) since But 7.4 gives all the niceness of typing, etc, so that would be my suggestion. A lot of libraries use 7.4 as minimum now. The Geocoder itself aims at 7.3: Also note that security fixes have not been supported anymore for 7.0 since january 2019 |
I see supporting PHP 7.0 will need some workarounds and I agree it's not worth it. I'm aware of all the niceness in PHP 7.4, but for this one class library I don't feel the urge to have those available so then I'd like to go for PHP 7.2 as minimum. |
Tried it with
The combination |
The testsuite is compatible with PHPUnit 7-9, so we can use |
Allow installing this provider on PHP 8