Fix non-tarballed SDK installation with remote URL #7312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4714ea9 introduced a regression where non-tarball SDKs could not be installed from a remote URL due to the wrong assumption that the downloaded file would always be a tarball. This commit fixes the issue by checking the file extension part of the URL for every supported archive format, then falling back to the tarball format if no supported extension is found.
kateinoigakukun
requested review from
bnbarham,
MaxDesiatov,
neonichu and
tomerd
as code owners
|
@swift-ci Please smoke test |
|
@swift-ci Please test |
MaxDesiatov
approved these changes
Feb 5, 2024
kateinoigakukun
added a commit
to kateinoigakukun/swift-package-manager
that referenced
this pull request
Feb 5, 2024
### Motivation: 4714ea9 introduced a regression where non-tarball SDKs could not be installed from a remote URL due to the wrong assumption that the downloaded file would always be a tarball. This issue exists in 5.10 release branch, so will cherry-pick after merging this PR. ### Modifications: This commit fixes the issue by checking the file extension part of the URL for every supported archive format, then falling back to the tarball format if no supported extension is found. ### Result: Non-tarball SDK artifact bundles can be installed from remote URL.
MaxDesiatov
pushed a commit
that referenced
this pull request
Apr 3, 2024
) * **Explanation**: 4714ea9 introduced a regression where non-tarball SDKs could not be installed from a remote URL due to the wrong assumption that the downloaded file would always be a tarball. * **Scope**: Experimental Swift SDK installation * **Risk**: Low, only affects to `swift experimental-sdk` command, which is still experimental. Also doesn't impact other binaries or SwiftPM clients/libraries. * **Testing**: Some new unit tests are added in this change. * **Reviewer**: @MaxDesiatov * **Main branch PR**: #7312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
4714ea9 introduced a regression where non-tarball SDKs could not be installed from a remote URL due to the wrong assumption that the downloaded file would always be a tarball.
This issue exists in 5.10 release branch, so will cherry-pick after merging this PR.
Modifications:
This commit fixes the issue by checking the file extension part of the URL for every supported archive format, then falling back to the tarball format if no supported extension is found.
Result:
Non-tarball SDK artifact bundles can be installed from remote URL.